Update test suite and report failed assertions - #501
Conversation
Sorry, something went wrong.
Small update: Restarted build to confirm that segfaults are indeed fixed with PHP 8.2.4 and PHP 8.1.17 releases. The PHP 8.1 build now executes successfully, the PHP 8.2 build no longer segfaults but is still broken as expected. This PR is now only awaiting the PRs linked above, I'll make sure to update this PR once releases are available. |
Sorry, something went wrong.
|
Small update: Updated now that https://github.com/reactphp/promise/releases/tag/v2.10.0 has been released. This PR is still awaiting 3 other releases linked above. |
Sorry, something went wrong.
|
Small update: Updated now that https://github.com/reactphp/event-loop/releases/tag/v1.4.0 has been released. This PR is now still awaiting 2 other releases linked above. |
Sorry, something went wrong.
|
Small update: Updated now that https://github.com/reactphp/socket/releases/tag/v1.13.0 has been released. This PR is now only awaiting the Stream component release linked above. |
Sorry, something went wrong.
|
Final update: Updated now that https://github.com/reactphp/stream/releases/tag/v1.3.0 has been released. This PR no longer targets any beta releases and is now finally ready for review! |
Sorry, something went wrong.
SimonFrings
left a comment
There was a problem hiding this comment.
🎉
Sorry, something went wrong.
WyriHaximus
left a comment
There was a problem hiding this comment.
Whoop whoop 🎉 !
Sorry, something went wrong.
Builds on top of #491, #455, #450, reactphp/socket#299, reactphp/socket#300 and reactphp/event-loop#264.
Marking this as WIP because this is currently awaiting a number of releases. PRs reactphp/event-loop#264, reactphp/promise#241 and reactphp/stream#165 need to be released to fix PHP 8.2 compatibility for the test suite, plus reactphp/socket#299 for legacy HHVM. Additionally, PHP 8.1 and PHP 8.2 builds currently segfault, likely due to php/php-src#10496 which should be fixed in PHP 8.2.4 (tagged just yesterday, not yet available through shivammathur/setup-php). I'll make sure to update this PR once releases are available. [update 1: segfaults fixed with PHP 8.2.4 and PHP 8.1.17] [update 2: updated to all stable releases]