[RFC] Improve tests to temporarily downgrade to Xdebug 3.4.1 due to segfaults - #322
[RFC] Improve tests to temporarily downgrade to Xdebug 3.4.1 due to segfaults#322clue wants to merge 1 commit into
Conversation
Sorry, something went wrong.
PaulRotmann
left a comment
There was a problem hiding this comment.
In my opinion, we should report the problem upstream to Xdebug in order to potentially find a final solution.
The workaround itself does solve the problem locally, but I can imagine that it might reappear at some point in the future and cost us a lot of time again.
By reporting the issue upstream, we might be able to resolve the problem at the root.
Sorry, something went wrong.
|
I'm with @PaulRotmann on this one. This should be reported upstream first, and we should only implement it if it blocks us. Once the issue is resolved upstream, we can then revert that change. Alternatively we could also consider using PCOV for coverage instead. |
Sorry, something went wrong.
|
I've managed to come up with a reproducible script that shows this is a bug in Xdebug 3.4.2 only with nested fibers and have reported this upstream accordingly last week: https://bugs.xdebug.org/view.php?id=2332. This is something that took the better half of the day. The bad news is this is something that will affect pretty much any project using fibers and Xdebug with code coverage enabled. The good news is this should not affect production at least. I'm not sure how to best proceed here at the moment. I think it's best resolved upstream and there's hope this will happen within a reasonable time frame. If not, we would have to go through all affected repositories (talking a few dozens here, times number of supported version branches), pin this to an old Xdebug version and eventually revert all these changes once an upstream fix is released. Fingers crossed we can avoid this. |
Sorry, something went wrong.
|
Lets wait before Derick replies about reverting the changes or not before considering that. |
Sorry, something went wrong.
This changeset updates the test environment to work around a segfault with Xdebug 3.4.2. Right now, this causes an unrelated build error for all builds on Windows and macOS with PHP 8.1+ (see also clue/reactphp-redis#173 and clue/framework-x#276).
I've tried multiple approaches and it looks like this issue does not occur in Xdebug 3.4.1. The Linux builds happen to use the correct version, macOS can be downgraded just fine, but unfortunately I've been unable to downgrade on Windows (shivammathur/setup-php#923).
I wonder how widespread this problem would be exactly, as I don't see anything special that this project would execute (except perhaps for Fibers as of #296?). In either case, we should probably report this upstream to Xdebug and/or shivammathur/setup-php.
Builds on top of #321, #238 and clue/framework-x#276 and clue/reactphp-redis#173