Add FileSystemProvider for jdt scheme (fixes #4038) - #4474
Open
MeherSru wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
In order to get the file system provider working, I think eclipse-jdtls/eclipse.jdt.ls#3855 should start working after we upgrade to vscode-languageclient >= 10 in vscode-java. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Then we can remove all this glue code for jdt:// completely |
Sorry, something went wrong.
Copy link
Copy Markdown
|
MeherSru:fix-4038-jdt-filesystem-provider |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, vscode-java only knows how to show jdt:// files (like
decompiled class files) inside an editor tab. But some tools try to
read these files directly using VS Code's normal file-reading API,
and that was crashing with "ENOPRO: No file system provider found".
This PR adds proper support for that, so those calls work instead of
crashing. It reuses the same logic that was already fetching the file
content for the editor tab, so nothing about the existing behavior
changes. Actions like editing, deleting, or renaming these files are
still blocked, since they're read-only anyway.
Fixes #4038.