fix(feature-manager): mark token-requiring features OFF when token is missing - #9990
Closed
Battleplus wants to merge 1 commit into
Closed
fix(feature-manager): mark token-requiring features OFF when token is missing#9990Battleplus wants to merge 1 commit into
Battleplus wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
`repo-header-info` reserves ~6em in the breadcrumb while it loads, and that space is only released when the feature actually runs (`rgh-repo-header-info-updated`). When no personal token is configured, `expectToken` throws before the feature ever runs, leaving the spacer permanently empty (refined-github#9986). Set the same `rgh-OFF-<feature>` attribute the disabled CSS-only path uses, so rules guarded by `html:not([rgh-OFF-…])` stop reserving space. Re-check on the next navigation so a token added later gets picked up. Closes refined-github#9986
Copy link
Copy Markdown
|
This looks like an AI-generated PR, so we're preemptively closing it. If you're human and tested it, include a screenshot/video/gif of the working PR and we can reopen the PR. Don't open more PRs until this one is resolved. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9986 — repo-header-info leaves ~6em of dead space in the breadcrumbs when no personal token is configured.
What's happening
The fix
When a requiresToken feature can't run because expectToken() rejects, the feature-manager now sets the same rgh-OFF-<feature> attribute that the disabled CSS-only path already uses. Rules guarded by html:not([rgh-OFF-repo-header-info]) stop applying, so the breadcrumb spacer collapses instead of staying empty.
It continues to the next navigation event, so if the user adds a token later it gets picked up on the next page load (same re-check cadence as the existing CSS-only OFF loop).
Verified
No UI change when a token is present (attribute only set on the missing-token path).