FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix operator precedence hole in IsCompatibleType by TetzkatLipHoka · Pull Request #302 · remobjects/pascalscript · GitHub

Fix operator precedence hole in IsCompatibleType - #302

Open
TetzkatLipHoka wants to merge 1 commit into
remobjects:masterfrom
TetzkatLipHoka:fix/iscompatibletype-precedence
Open

TetzkatLipHoka wants to merge 1 commit into
remobjects:masterfrom
TetzkatLipHoka:fix/iscompatibletype-precedence

Conversation

Copy link
Copy Markdown

One line of the big compatibility expression was missing parentheses:

(((p1.basetype = btPchar) or (p1.BaseType = btString)) and
(p2.BaseType = btWideString) or (p2.BaseType = btUnicodeString)) or

'and' binds stronger than 'or', so the (p2 = btUnicodeString) term stood
alone: ANY destination type was considered assignment-compatible with a
UnicodeString source. Since script 'string' is btUnicodeString nowadays,
these all compiled without error and only failed at runtime (or
corrupted data):

var i: Integer; s: string; ... i := s;
var b: Boolean; s: string; ... b := s;
var d: Double; s: string; ... d := s;

With the added parentheses the term applies - as clearly intended - only
to btPchar/btString destinations. String-to-string, WideString and Char
conversions keep compiling as before.

🤖 Generated with Claude Code

One line of the big compatibility expression was missing parentheses:

  (((p1.basetype = btPchar) or (p1.BaseType = btString)) and
    (p2.BaseType = btWideString) or (p2.BaseType = btUnicodeString)) or

'and' binds stronger than 'or', so the (p2 = btUnicodeString) term stood
alone: ANY destination type was considered assignment-compatible with a
UnicodeString source. Since script 'string' is btUnicodeString nowadays,
these all compiled without error and only failed at runtime (or
corrupted data):

  var i: Integer; s: string; ... i := s;
  var b: Boolean; s: string; ... b := s;
  var d: Double;  s: string; ... d := s;

With the added parentheses the term applies - as clearly intended - only
to btPchar/btString destinations. String-to-string, WideString and Char
conversions keep compiling as before.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL