Accept Delphi's 'packed' keyword in type declarations (fixes #246) - #314
Open
TetzkatLipHoka wants to merge 1 commit into
Open
TetzkatLipHoka wants to merge 1 commit into
TetzkatLipHoka wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…ts#246) The parser rejected 'packed record', 'packed array' and 'packed set' in script type sections and AddTypeS declarations, although PascalScript records and arrays are always packed anyway - Delphi type declarations could not be pasted into scripts unchanged. ReadType now skips a leading 'packed' when a structured type (record/array/set) follows; anything else after 'packed' is still an error, and the memory layout is unaffected. Repro (fails on master, passes with this change, DCC32+DCC64): type TP = packed record x, y: Integer; end; // script type section Sender.AddTypeS('THostPacked', 'packed record a: Byte; b: Integer; end'); Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser rejected 'packed record', 'packed array' and 'packed set' in
script type sections and AddTypeS declarations, although PascalScript
records and arrays are always packed anyway - Delphi type declarations
could not be pasted into scripts unchanged.
ReadType now skips a leading 'packed' when a structured type
(record/array/set) follows; anything else after 'packed' is still an
error, and the memory layout is unaffected.
Repro (fails on master, passes with this change, DCC32+DCC64):
type TP = packed record x, y: Integer; end; // script type section
Sender.AddTypeS('THostPacked', 'packed record a: Byte; b: Integer; end');
Fixes #246.
🤖 Generated with Claude Code