| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
This PR updates the schema override-path updater to support appending to lists when the override key targets an index equal to len(list), enabling CLI/YAML overrides to add new list items rather than only replacing existing ones.
Changes:
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/rendercv/schema/override_dictionary.py | Updates list index validation and mutation logic to support append-at-end behavior during overrides. |
| tests/schema/test_override_dictionary.py | Updates index bounds expectations and adds a test ensuring index-at-len appends to the list. |
tests/schema/test_override_dictionary.py:204
@settings(deadline=None)
@given(items=st.lists(st.text(max_size=10), min_size=1, max_size=5))
def test_list_index_at_len_appends_to_list(self, items: list[str]) -> None:
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
| @settings(deadline=None) | ||
| @given(items=st.lists(st.text(max_size=10), min_size=1, max_size=5)) | ||
| def test_list_index_out_of_bounds_raises(self, items: list[str]) -> None: |
| Back | FazBrowse Home | New Git URL |
In ovverrides you cannot append to a list. This PR makes it possible. Tests also fixed. Minimal changes.