install ocaml in dockerfile instead of postCreate.sh - #8230
Merged
tsnobip merged 7 commits intoJan 26, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
|
rescript
npm i https://pkg.pr.new/rescript-lang/rescript@8230
npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@8230
npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@8230
npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@8230
npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@8230
npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@8230
npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@8230 commit: c3dfc0b |
Sorry, something went wrong.
tsnobip
marked this pull request as ready for review
January 26, 2026 11:41
cknitt
reviewed
Jan 26, 2026
Comment thread
.devcontainer/postCreate.sh
| echo 'eval $(opam env)' >> ~/.bashrc | ||
|
|
||
| nvm install | ||
|
|
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Why are we removing this part?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
shell setup is now taken care of in opam init.
nvm install was not working because postCreate.sh gets run in a degraded shell env that can't find nvm so it was useless, nvm does run normally in a dev container terminal though and node version gets correctly set up.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Ah I see --enable-shell-hook
Sorry, something went wrong.
cknitt
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it speeds up the test a bit but opam install has to be in postCreate.sh because there's no access to the repo in the docker build phase.