Rewatch: don't suppress progress messages under -v/-vv - #8371
Merged
jfrolich merged 1 commit intoApr 19, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Change show_progress from `log_level_filter == LevelFilter::Info` to `>= LevelFilter::Info` so that verbose flags (-v, -vv) add debug output without silencing progress messages like 'Finished compilation'.
cknitt
approved these changes
Apr 19, 2026
jfrolich
enabled auto-merge (squash)
April 19, 2026 12:46
Copy link
Copy Markdown
|
rescript
npm i https://pkg.pr.new/rescript@8371
npm i https://pkg.pr.new/@rescript/darwin-arm64@8371
npm i https://pkg.pr.new/@rescript/darwin-x64@8371
npm i https://pkg.pr.new/@rescript/linux-arm64@8371
npm i https://pkg.pr.new/@rescript/linux-x64@8371
npm i https://pkg.pr.new/@rescript/runtime@8371
npm i https://pkg.pr.new/@rescript/win32-x64@8371 commit: dfab8db |
Sorry, something went wrong.
cknitt
pushed a commit
that referenced
this pull request
May 3, 2026
Change show_progress from `log_level_filter == LevelFilter::Info` to `>= LevelFilter::Info` so that verbose flags (-v, -vv) add debug output without silencing progress messages like 'Finished compilation'.
cknitt
pushed a commit
that referenced
this pull request
May 4, 2026
Change show_progress from `log_level_filter == LevelFilter::Info` to `>= LevelFilter::Info` so that verbose flags (-v, -vv) add debug output without silencing progress messages like 'Finished compilation'.
cknitt
pushed a commit
that referenced
this pull request
May 16, 2026
Change show_progress from `log_level_filter == LevelFilter::Info` to `>= LevelFilter::Info` so that verbose flags (-v, -vv) add debug output without silencing progress messages like 'Finished compilation'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change show_progress from log_level_filter == LevelFilter::Info to >= LevelFilter::Info so that -v / -vv add debug output without also silencing progress messages like "Finished compilation".
Small UX fix split out of #8241.
Test plan
🤖 Generated with Claude Code