| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Sorry, something went wrong.
|
rescript
npm i https://pkg.pr.new/rescript@8467
npm i https://pkg.pr.new/@rescript/darwin-arm64@8467
npm i https://pkg.pr.new/@rescript/darwin-x64@8467
npm i https://pkg.pr.new/@rescript/linux-arm64@8467
npm i https://pkg.pr.new/@rescript/linux-x64@8467
npm i https://pkg.pr.new/@rescript/runtime@8467
npm i https://pkg.pr.new/@rescript/win32-x64@8467 commit: 4e80945 |
Sorry, something went wrong.
The coverage suite previously only ran `node scripts/test.js -all` (mocha/build/ounit/docstrings), leaving compiler/gentype and the whole analysis/ tree uninstrumented in the report. Run the additional suites under the same BISECT_FILE env so their instrumented binaries accumulate counters: - gentype tests compile via the instrumented bsc in BIN_DIR - analysis tests run the instrumented rescript-editor-analysis - tools tests run the instrumented rescript-tools (links analysis + reanalyze) Use the analysis suite's test-analysis-binary target rather than its full test: the reanalyze tests invoke the binary via `dune exec`, which rebuilds it uninstrumented and strips instrumentation from the shared _build artifacts, so they produce no coverage and would corrupt the build for later suites.
The syntax suite (scripts/test_syntax.sh) is a merge-gating test on all platforms but contributed no coverage: it drives the res_parser binary, which is instrumented (it carries the bisect_ppx stanza and links the instrumented compiler/syntax lib) and is invoked from _build/install/default/bin, the same pattern as the analysis tests. Run it under BISECT_FILE so compiler/syntax is no longer a blind spot. ROUNDTRIP_TEST=1 matches Linux CI and also exercises the printer paths.
The reanalyze tests invoke rescript-tools through `dune exec`, so they ran an uninstrumented binary and produced no coverage (and a plain `dune exec` would rebuild the shared _build artifacts uninstrumented). Set DUNE_INSTRUMENT_WITH=bisect_ppx (the env-var form of `--instrument-with`) for the analysis suite so that `dune exec` matches the instrumentation config coverage-build already used. dune finds the build up to date, runs the instrumented binary, and reanalyze now contributes coverage for analysis/reanalyze without any test-script changes. Switch the analysis line from test-analysis-binary to the full test target to pull reanalyze in.
The DUNE_INSTRUMENT_WITH change alone routed the reanalyze tests to an instrumented rescript-tools, but the reanalyze library itself declared no instrumentation backend, so its own 58 source files recorded zero coverage (only the analysis/tools code it links was counted). Add the (instrumentation (backend bisect_ppx)) stanza — matching every other analysis/* and tools/* library — so analysis/reanalyze/src is measured. Verified locally: reanalyze goes from 0 to ~61% line coverage in the report. The stanza is a no-op for normal builds (it only activates under --instrument-with / DUNE_INSTRUMENT_WITH).
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #8467 +/- ##
===========================================
+ Coverage 60.95% 74.34% +13.39%
===========================================
Files 374 450 +76
Lines 54117 61511 +7394
===========================================
+ Hits 32986 45730 +12744
+ Misses 21131 15781 -5350 see 215 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
I was looking at the coverage report wondering why some parts didn't show tests only to find out that node scripts/test.js -all doesn't infact include analysis or gentype or syntax tests 🤦🏼♂️
Since these are run in the CI pipeline I'm including them in coverage.