FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Preserve multibyte characters when wrapping long source lines by fhammerschmidt · Pull Request #8520 · rescript-lang/rescript · GitHub

/ rescript Public

Preserve multibyte characters when wrapping long source lines - #8520

Merged
fhammerschmidt merged 2 commits into
masterfrom
fix-rewatch-multichar-emdash-panic
Jul 27, 2026
ConversationCommits (2)ChecksFiles changed
Merged

Preserve multibyte characters when wrapping long source lines#8520
fhammerschmidt merged 2 commits into
masterfrom
fix-rewatch-multichar-emdash-panic

Conversation

fhammerschmidt commented Jul 23, 2026

Copy link
Copy Markdown
Member

chatgpt-codex-connector Bot reviewed Jul 23, 2026
View reviewed changes

chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0720a42e7c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread compiler/ml/code_frame.ml

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.70%. Comparing base (fc2c00f) to head (37fece4).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8520   +/-   ##
=======================================
  Coverage   74.70%   74.70%           
=======================================
  Files         458      458           
  Lines       62360    62366    +6     
=======================================
+ Hits        46587    46593    +6     
  Misses      15773    15773
Files with missing lines Coverage Δ
compiler/ml/code_frame.ml 94.53% <100.00%> (+0.17%) ⬆️
tests/ounit_tests/ounit_utf8_test.ml 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pkg-pr-new Bot commented Jul 23, 2026

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@8520

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@8520

@rescript/darwin-x64

npm i https://pkg.pr.new/@rescript/darwin-x64@8520

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@8520

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@8520

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@8520

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@8520

commit: 37fece4

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8520

fhammerschmidt merged commit 2f97455 into master Jul 27, 2026
29 checks passed
fhammerschmidt deleted the fix-rewatch-multichar-emdash-panic branch July 27, 2026 14:27
cknitt mentioned this pull request Aug 19, 2026
Merged
cknitt pushed a commit that referenced this pull request Aug 21, 2026
Preserve multibyte characters when wrapping long source lines (#8520)
6eef756 
* Preserve multibyte characters when wrapping long source lines in compiler code frames

* Changelog
cknitt pushed a commit that referenced this pull request Aug 23, 2026
Preserve multibyte characters when wrapping long source lines (#8520)
46ef1eb 
* Preserve multibyte characters when wrapping long source lines in compiler code frames

* Changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
cknitt cknitt approved these changes
jfrolich Awaiting requested review from jfrolich

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL