FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

create documentation of button component by enieber · Pull Request #22 · rescript-react-native/rescript-react-native.github.io · GitHub

create documentation of button component - #22

Closed
enieber wants to merge 2 commits into
rescript-react-native:srcfrom
enieber:patch-2
Closed

create documentation of button component#22
enieber wants to merge 2 commits into
rescript-react-native:srcfrom
enieber:patch-2

Conversation

enieber commented Jun 7, 2021

Copy link
Copy Markdown
Contributor

documentation of button component based in the doc of react-native with samples

enieber mentioned this pull request Jun 7, 2021
20 tasks

MoOx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Let's not just copy the page from RN website, this adds no value. We should instead focus on what is different from there docs.

Comment thread docs/button.md Outdated

A basic button component that should render nicely on any platform. Supports a minimal level of customization.

If this button doesn't look right for your app, you can build your own button using [TouchableOpacity](touchableopacity) or [TouchableWithoutFeedback](touchablewithoutfeedback).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pressable are recommended instead of Touchables.

Comment thread docs/button.md Outdated

## Example

```SnackPlayer name=Button%20Example

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Snack don't works on our website and can't.
Maybe a simple example without other component could be nice for a start, like for Text.

Comment thread docs/button.md Outdated

| Type |
| ---------------------------------- |
| function([PressEvent](pressevent)) |

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

link don't work.

Comment thread docs/button.md Outdated

## Props

### <div class="label required basic">Required</div>**`onPress`**

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this css things doesn't work am I right?

enieber requested a review from MoOx June 7, 2021 07:43

MoOx commented Oct 5, 2022

Copy link
Copy Markdown
Member

@davisuga feel free to take this and address issue I mentioned :)

enieber closed this Nov 4, 2022
enieber deleted the patch-2 branch November 4, 2022 19:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL