Fix: AMD Ryzen/Threadripper skipping the AMD Vanilla kernel patches on Windows - #68
Closed
Epic34-cyberdudder wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
AMD Vanilla (AMD-OSX/AMD_Vanilla, vendored in amd_patches.plist) is an XNU *processor* patch set. It is applied when profile.cpu_vendor == "amd" and must never be applied on an Intel CPU — an AMD Radeon GPU on an Intel host needs no kernel patch. - hardware.py: when the Windows CPU marketing name contains neither "intel" nor "amd", fall back to Win32_Processor.Manufacturer (AuthenticAMD / GenuineIntel) so a Ryzen/Threadripper still routes into the AMD path. - config_gen.py: _amd_kernel_patches() now returns [] for any non-AMD CPU as a hard guard, plus a comment on why GPU vendor is irrelevant here. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> (cherry picked from commit 389e8f47aa007528acb3368b158510434dbdddfe)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_detect_cpu_windows() sets the vendor from the marketing name string:
Some CPUs (engineering samples, a few OEM strings) don't contain "intel" or "amd" → vendor = "unknown" → the build is treated as Intel → no AMD Vanilla kernel patches → kernel panic on an AMD box.
Fix
Two files, ~17 lines. No test changes needed.