GPU: show the PCI device-id on the scan screen; detect it on macOS - #69
Closed
Epic34-cyberdudder wants to merge 1 commit into
Closed
GPU: show the PCI device-id on the scan screen; detect it on macOS#69Epic34-cyberdudder wants to merge 1 commit into
Epic34-cyberdudder wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
- hardware.py: new format_device_id() / pci_id_device_part() helpers that accept every shape the per-OS detectors emit (8086:5917 / 0x5917 / 5917 / 1002:73FF) - macOS: _detect_gpu_macos now parses "Vendor ID" / "Device ID" from SPDisplaysDataType and buckets them to the right GPU block (was not populating gpu_device_id / dgpu_device_id at all before) - scan results screen (TUI + tkinter GUI): GPU / dGPU lines now show "device-id vvvv:dddd" when known - config_editor.suggest_framebuffers() and the Windows iGPU->CPU-gen lookup now tolerate the vendor:device form - hardware.py __main__ debug dump prints dGPU + device ids - tests: device-id formatting + macOS SPDisplays parsing Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> (cherry picked from commit da6aa634d7619e72eb4290228756b952028516a6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tests
Added device-id formatting + macOS SPDisplaysDataType parsing tests.