test: make test_ssdt / test_recovery pass on Windows - #72
Closed
Epic34-cyberdudder wants to merge 1 commit into
Closed
test: make test_ssdt / test_recovery pass on Windows#72Epic34-cyberdudder wants to merge 1 commit into
Epic34-cyberdudder wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
- Acpi0007DetectionTests._inspect reopened a still-open NamedTemporaryFile, which fails on Windows — _inspect_dsdt then hit its read-error path and the assertions failed. Write/close/inspect/unlink instead. - test_shared_command_builder_includes_output_directory hard-coded the POSIX string "/tmp/recovery"; compare against str(Path(...)) so it also passes where os.sep is a backslash. Both pass on POSIX today; this only widens them. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tests fail on a Windows checkout (green on POSIX / CI). This only widens them.