Implement unique job insertions - #10
Merged
brandur merged 1 commit intoApr 28, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
brandur
force-pushed
the
brandur-unique-jobs
branch
from
0bcf50d to
76db952
Compare
April 28, 2024 03:32
Implement unique job insertion in a way that's compatible with the main
Go library. Unique opts live on insert opts just like in Go, and we
copy as much of its API as possible including return result.
insert_res = client.insert(args, insert_opts: River::InsertOpts.new(
unique_opts: River::UniqueOpts.new(
by_args: true,
by_period: 15 * 60,
by_queue: true,
by_state: [River::JOB_STATE_AVAILABLE]
)
)
# contains either a newly inserted job, or an existing one if insertion was skipped
insert_res.job
# true if insertion was skipped
insert_res.unique_skipped_as_duplicated
brandur
force-pushed
the
brandur-unique-jobs
branch
from
76db952 to
32af5cf
Compare
April 28, 2024 03:34
brandur
added a commit
that referenced
this pull request
Apr 28, 2024
Prepare release `v0.3.0` which largely includes unique jobs from #10. Also tweak the publishing instructions, which were once again, still somewhat wrong (building a gem doesn't lead directly to an updated `Gemfile.lock`).
Merged
brandur
added a commit
that referenced
this pull request
Apr 28, 2024
brandur
added a commit
that referenced
this pull request
Apr 28, 2024
Follows up #10 with a few minor reworks to the test suite. Prefer `job_args` over `args` as a variable name, and add a `job_args_to_row` helper for convenience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement unique job insertion in a way that's compatible with the main
Go library. Unique opts live on insert opts just like in Go, and we
copy as much of its API as possible including return result.
insert_res = client.insert(args, insert_opts: River::InsertOpts.new( unique_opts: River::UniqueOpts.new( by_args: true, by_period: 15 * 60, by_queue: true, by_state: [River::JOB_STATE_AVAILABLE] ) ) # contains either a newly inserted job, or an existing one if insertion was skipped insert_res.job # true if insertion was skipped insert_res.unique_skipped_as_duplicated