Include all files in lib paths in various gems - #26
Merged
brandur merged 1 commit intoAug 21, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
brandur
approved these changes
Aug 21, 2024
brandur
added a commit
that referenced
this pull request
Aug 21, 2024
Prepare release 0.6.1, containing the Ruby gem fix from #26.
Merged
brandur
added a commit
that referenced
this pull request
Aug 21, 2024
Prepare release 0.6.1, containing the Ruby gem fix from #26.
Copy link
Copy Markdown
Contributor
|
Thanks @yawboakye! Yeah, this seems to be a major oversight. I guess it never happened to me before because I generally have done all my testing pointing manually to the gem directory on my local disk (basically so I'm always using the latest code). I just cut and pushed version 0.6.1 with your changes, which should resolve the problem. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My Rails application refused to build after I added the riverqueue and riverqueue-activerecord gems. The logs suggested that the errors were due to missing files (see attached screenshot). When I checked the gemspec, the s.files definition included only one file, for all three gems. I modified them to include all files in the various lib directories, changed the gem source to my github fork, and the build succeeded.
Perhaps this failure is unique to my environment (Docker on Railway, bundler 2.5.17), otherwise maybe the definition should be expanded to include all files in the lib directories? This seems to be the default configuration for gems created with bundle gem GEM_NAME.