Allow by period uniqueness to be based off scheduled time - #39
Merged
brandur merged 1 commit intoJan 25, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
bgentry
approved these changes
Jan 25, 2025
bgentry
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Sorry, something went wrong.
This one follows up [1] in the main repository, in which we fix what could be considered a bug in that by period uniqueness was always based off the current time, even though a job may have been given a custom value for `scheduled_at`, which really should take precedence. [1] riverqueue/river#734
brandur
force-pushed
the
brandur-scheduled-at-period
branch
from
0bd8d8f to
0451fce
Compare
January 25, 2025 21:36
Copy link
Copy Markdown
Contributor
Author
|
Thx. Added changelog too. |
Sorry, something went wrong.
brandur
added a commit
that referenced
this pull request
Apr 12, 2025
I just noticed that we've had an unreleased change sitting in `master` since December since changes in this gem are pretty rare unfortunately. Let's cut a release just so we can get that change (#39) finally shipped out.
Merged
brandur
added a commit
that referenced
this pull request
Apr 12, 2025
I just noticed that we've had an unreleased change sitting in `master` since December since changes in this gem are pretty rare unfortunately. Let's cut a release just so we can get that change (#39) finally shipped out.
brandur
added a commit
that referenced
this pull request
Apr 12, 2025
I just noticed that we've had an unreleased change sitting in `master` since December since changes in this gem are pretty rare unfortunately. Let's cut a release just so we can get that change (#39) finally shipped out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one follows up [1] in the main repository, in which we fix what
could be considered a bug in that by period uniqueness was always based
off the current time, even though a job may have been given a custom
value for scheduled_at, which really should take precedence.
[1] riverqueue/river#734