Encryption certificate inclusion - #224
Open
SharkMachine wants to merge 1 commit into
Open
SharkMachine wants to merge 1 commit into
SharkMachine wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Adds the possibility to include encryption certificate with with xenc:EncryptedData/dsig:KeyInfo/xenc:EncryptedKey/dsig:KeyInfo/dsig:X509Data/dsig:X509Certificate
Copy link
Copy Markdown
|
Looks great! Can we get this merged in? @robrichards |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@robrichards I have to use a fork of this library because these changes are needed for web services to Danske Bank to work. |
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
|
@SharkMachine Thinking about the logic a bit as it does change the current behavior slightly. Now you must pass in includeKeyInfo as true for it to include the name whereas before as long as the key name was not empty it would add it. Would prefer to keep the existing behavior while also adding this as to avoid any BC issues |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the possibility to include encryption certificate with with xenc:EncryptedData/dsig:KeyInfo/xenc:EncryptedKey/dsig:KeyInfo/dsig:X509Data/dsig:X509Certificate