Also, the same commit(4ac5564) caused this issue will also cause empty function/module/class decompile to return instead of pass for both python2 and python3:

class Test:
    pass

Decompiled:

class Test:
    return

I haven't figure out how to resolve this.

@wangym5106 For the next week and a half, I'm out of town on vacation. I will look at this, though, when I get home.

I just had a chance to look at. Allow me to give a high-level overview.

At the base level, the return None is redundant. Redundant isn't per se wrong, just unnecessary.

I've been a little sloppy here, and I guess my excuse is that there's so much other stuff that's wrong, that this has taken priority. And it's also taken me a while to try to organize the process to make sense so tht the code can scale easily.

The good part of the PR is that the changes here are done after scanning and parsing.

For things like this — what we have is correct but maybe not idiomatic — what is used is a "transformation rule"

See https://github.com/rocky/python-uncompyle6/blob/master/uncompyle6/semantics/transform.py for examples of transformation rules. This is also mentioned briefly in the BlackHat Asia talk.

This issue and another issue (#521 , that's a real wrong) is both caused by same reason: different attr & pattr between python 2 and 3. So for a better fix for these issues, can we unify the attr & pattr across python versions?

@wangym5106 want to try revising this as a transformation rule for n_return?

I'd like to. But actually all L1250-L1270 is for removing redundant return, should be move to a transformation rule. For this specific issue, it's caused by redundant return is removed successfully in python3 but failed in python2.
So I think we can hold this issue, after attr & pattr issue resolved, then move this to transformation rule.