FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add Test Case for rclcpp_action Where the Status Message is Received Before the Service Response by tony-laza · Pull Request #2781 · ros2/rclcpp · GitHub

/ rclcpp Public

Add Test Case for rclcpp_action Where the Status Message is Received Before the Service Response - #2781

Open
tony-laza wants to merge 1 commit into
ros2:rollingfrom
tony-laza:tony-laza/receive_status_before_service_response
Open

Add Test Case for rclcpp_action Where the Status Message is Received Before the Service Response#2781
tony-laza wants to merge 1 commit into
ros2:rollingfrom
tony-laza:tony-laza/receive_status_before_service_response

Conversation

Copy link
Copy Markdown

Add test cases to the rclcpp_action clients where the Executing status response is received before the service callback. The test leverages a specific sequence of spin() invocation on the executors, however, it is possible to reproduce this non-deterministically in other cases. A forthcoming issue ticket will give more details.

Signed-off-by: Tony <tony@lazamedical.com>
tony-laza force-pushed the tony-laza/receive_status_before_service_response branch from c103966 to cb28826 Compare March 27, 2025 21:11
tony-laza marked this pull request as draft March 27, 2025 21:11
tony-laza marked this pull request as ready for review March 27, 2025 21:52

Copy link
Copy Markdown
Author

#2782

Comment on lines +456 to +457
// Spin until the client receives the goal
dual_spin_until_future_complete(future_goal_handle);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

in this particular case, i believe that GoalResponse(accepted) and Status messages are already in the rmw implementation, and the question here is which should be taken 1st. currently, the order to take the action entities is feedback, status, goal_response, result_response and cancel_response. so that status is going to be taken and processed before goal_response.

but this order only matters when the messages are already in the queue of rmw implementation.

alsora commented Apr 13, 2025

Copy link
Copy Markdown
Collaborator

This topic was discussed last week during the client library working group.
See here for a decision on how we should address the problem to ensure the ordering of events #2782 (comment)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL