FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Reject incompatible parameter range constraints by aiqubits · Pull Request #3243 · ros2/rclcpp · GitHub

/ rclcpp Public

Reject incompatible parameter range constraints - #3243

Open
aiqubits wants to merge 1 commit into
ros2:rollingfrom
aiqubits:fix/issue-2184-parameter-range-types
Open

Reject incompatible parameter range constraints#3243
aiqubits wants to merge 1 commit into
ros2:rollingfrom
aiqubits:fix/issue-2184-parameter-range-types

Conversation

Copy link
Copy Markdown

Fixes #2184.

Range constraints were previously ignored when the parameter type did not
match one of the existing numeric range validation branches. For example, a
boolean parameter could be declared with an integer range constraint.

This change:

  • rejects integer range constraints for types other than integers and integer arrays;
  • rejects floating-point range constraints for types other than doubles and double arrays;
  • validates statically typed parameters that are declared without an initial value;
  • validates dynamically typed parameters whenever they acquire or change their concrete type;
  • preserves the existing scalar and per-element array range validation behavior.

Testing

  • Added coverage for incompatible initialized parameter declarations.
  • Added coverage for statically typed declarations without initial values.
  • Added coverage for incompatible integer/floating-point range combinations.
  • Added coverage for dynamically typed parameters changing to an incompatible type.
  • Full test_node suite passed: 48/48 tests, using the equivalent patch with the
    rclcpp version matching the available archived Rolling dependencies.
  • git diff --check passed.

Signed-off-by: aiqubits <aiqubits@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disallow setting range constraints for types that should not have them

1 participant


Back | FazBrowse Home | New Git URL