FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: refresh the legacy screenshots for 1.44 by kelsos · Pull Request #143 · rotki/docs · GitHub

/ docs Public

docs: refresh the legacy screenshots for 1.44 - #143

Open
kelsos wants to merge 1 commit into
rotki:mainfrom
kelsos:docs/audit-legacy-screenshots
Open

docs: refresh the legacy screenshots for 1.44#143
kelsos wants to merge 1 commit into
rotki:mainfrom
kelsos:docs/audit-legacy-screenshots

Conversation

kelsos commented Aug 28, 2026
edited
Loading

Copy link
Copy Markdown
Member

Second pass over the legacy image corpus. 89 images reshot against a v1.44.0 build, one animation retired, and the prose the audit found wrong corrected alongside the pictures it belongs to. 14 images remain stale, and all but a handful are genuinely unreachable rather than merely unfinished.

The pattern worth knowing

The audit kept turning up text that no longer matched the app, not images that were merely old. A screenshot pass is a prose audit; roughly a quarter of what was inspected documented behaviour that had changed or gone.

  • Account creation described an Enable premium / Restore synced database toggle pair that does not exist. 1.44 runs a four-step stepper, so the numbered steps could not be followed at all.
  • The customized-event chip is gone. 1.44 marks the event with a small pencil badge and a tooltip. The mark matters beyond bookkeeping, because a redecode rebuilds events but skips the customized ones, and the page never said so.
  • The manual-price icon marks the derived total as well as the unit price, so a balance row carries it twice. The page claimed one.
  • Oracle caches are managed from Manage Prices → Oracle Prices → Caches, not from the settings page the text pointed at.
  • Reusing an address-book name across chains is done by picking All Supported Chains; the toggle the text described was removed.
  • The RPC node table gained a Connectivity column, undocumented.
  • The CoinLedger importer was missing from the import list entirely.
  • docker_warning was the one image whose staleness understated a security risk: it showed pre-1.44 wording that gestured at a "potential risk" while the page's own prose already named the exposure.

Technique

Crop to the subject, and crop overlays to their own bounds rather than to the page behind them. Several images needed the drawer collapsed or a taller viewport so a table did not silently lose its last column — the 1400px viewport clips wide cards, and the lost column is invisible unless you go looking.

Callouts are drawn from each target's own bounding box rather than painted onto pixels, so they move when the UI moves. Where a numbered list was involved, one image per step usually beat numerals.

The global search GIF is replaced by two stills. An animation cannot be diffed against the app, which is exactly how a wrong claim survived on that page. Also drops 636 KB.

One image was re-cropped rather than reshot (redecode_status): its content was already correct for 1.44 and only the scrim padding was wrong. Cropping is not fabrication; reshooting it would have required a destructive purge of decoded events.

Staged data

Some pages could not be reached with the account as it stood. Where data was staged it is data a user could genuinely create, and the recipe is recorded next to the image:

  • Kraken staking is not fed by an exchange call — it filters history events on location and type — so events added through rotki's own Add new event feature fill the page, including the embedded events card.
  • The notes, calendar-reminder and manual-price shots are the same kind of thing: real features, exercised.
  • ETH2 staking needed nothing at all. The validators auto-detected once a history refresh had run.

One image is ahead of the code

staking/eth2_add_validator cannot be opened by clicking in 1.44. The Validators tab seeds a chain without choosing one, so the form falls through to the generic account branch and the public-key / index / ownership fields never render. Filed as rotki/rotki#13027 with the cause traced to a specific commit; the backend is fine.

Its state was forced from devtools to capture the form the page describes. If this merges before that fix, drop that image and the two prose steps above it — they cannot be followed until then. Everything else here stands on its own.

What remains stale, and why

  • Out of scope (6) — The Graph's own Studio, two Chrome DevTools screens, a terminal, dappnode, and debug_mode_set (Electron-only).
  • Blocked on data (2) — monerium_transactions, and not_processed, whose subject also changed: 1.44 replaced the bare orange icon with a missing-accounting-rule dialog, so its caption needs rewriting when it is reshot.
  • Reachable, not yet done (6) — the four premium_* sync and error states, and the PnL missing_acquisitions / missing_prices pair.

kelsos force-pushed the docs/audit-legacy-screenshots branch 7 times, most recently from a97be39 to ded32e1 Compare August 28, 2026 19:14
Recaptures 89 images against a v1.44.0 build and fixes the prose each
one turned out to contradict.

The pass kept finding text that no longer matched the app rather than
images that were merely old:

- account creation described an "Enable premium" / "Restore synced
  database" toggle pair that does not exist; it is a four step stepper
- the customized event chip is gone, 1.44 marks the event with a
  pencil badge and a tooltip, and the mark matters because a redecode
  skips customized events
- the manual price icon marks the derived total as well as the price,
  so a balance row carries it twice
- oracle caches are managed from Manage Prices, not from settings
- the address book entry is reused across chains by picking
  All Supported Chains, not by a toggle that was removed
- the RPC node table gained a Connectivity column
- the CoinLedger importer was undocumented
- a GIF that no longer matched the app is replaced by two stills

Framing follows the same rule throughout: crop to the subject, and
crop overlays to their own bounds rather than to the page behind them.
Several images needed the drawer collapsed or a taller viewport so a
table did not silently lose its last column.

Some pages were only reachable with staged data. Where that happened
the data is one a user could genuinely create, and the recipe is
recorded alongside the image.

The add-validator dialog is the exception: it cannot be opened by
clicking in 1.44, so its state was forced. Filed as rotki/rotki#13027.
Drop that image and the two steps above it if this merges first.
kelsos force-pushed the docs/audit-legacy-screenshots branch from ded32e1 to 9cbb90f Compare August 28, 2026 21:42
kelsos requested a review from yabirgb August 28, 2026 22:06
kelsos marked this pull request as ready for review August 28, 2026 22:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL