FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added ability to set proxy to http by ormus2002 · Pull Request #570 · rpush/rpush · GitHub

/ rpush Public

Added ability to set proxy to http - #570

Draft
ormus2002 wants to merge 2 commits into
rpush:masterfrom
ormus2002:add_proxy
ConversationCommits (2)ChecksFiles changed
Draft

Added ability to set proxy to http#570
ormus2002 wants to merge 2 commits into
rpush:masterfrom
ormus2002:add_proxy

Conversation

ormus2002 commented Oct 1, 2020

Copy link
Copy Markdown

No description provided.

ormus2002 commented Oct 1, 2020

Copy link
Copy Markdown
Author

Added proxy #208

benlangfeld reviewed Oct 1, 2020
View reviewed changes
Comment thread lib/rpush/daemon/dispatcher/http.rb
@app = app
@delivery_class = delivery_class
@http = Net::HTTP::Persistent.new(name: 'rpush')
@http.proxy = Rpush.config.proxy if Rpush.config.proxy.present?

benlangfeld Oct 1, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This only applies to HTTP dispatchers, and does not contemplate APNSv2/p8. Could you maybe add it to those dispatchers also?

ormus2002 Oct 1, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry but I didn't use APNS, so I cannot test it

benlangfeld Oct 1, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Would a spec not be enough to create confidence in its functionality?

stale Bot commented Oct 2, 2021

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. If this is still an issue, please leave another comment. This issue will be closed if no further activity occurs.
Thank you for all your contributions!

stale Bot added the stale label Oct 2, 2021
aried3r removed the stale label Oct 8, 2021
benlangfeld marked this pull request as draft September 9, 2024 15:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benlangfeld benlangfeld left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

enhancement needs-tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL