Don't manipulate bin scripts for jruby/ruby - #17
Conversation
Sorry, something went wrong.
In jruby/jruby#8875 we modified JRuby's distribution to always ship scripts for bin/jruby and bin/ruby: * bin/jruby and bin/ruby are versioned shell scripts that launch `/bin/sh bin/jruby.sh`. * bin/ruby.bat contains batch code to launch bin/ruby.exe. * No copying of scripts is done during the build and no tweaks are needed by installers to copy, link, or create additional bin/ commands. These changes now conflict with jruby-dev-builder's symlinking of bin/jruby to bin/ruby and its creation of bin/ruby.bat, so we remove the relevant steps.
|
The relevant changes were released in JRuby 10.0.1.0, so all dev/head builds should have picked up the bin changes long ago. This job has been failing for some time. |
Sorry, something went wrong.
|
Looks good, but have you seen ruby/setup-ruby#781 (comment) ? EDIT: so I think it might fail the same way here too on Windows |
Sorry, something went wrong.
|
FYI I just pushed 7c7bcb3 since windows-2019 is gone (same as ruby/ruby-builder@228ee88 but on this repo) |
Sorry, something went wrong.
|
I'll merge this as it's definitely a good change, and dev builds here are broken currently anyway. |
Sorry, something went wrong.
|
Interesting, dev builds are fine on Windows and there is jruby.exe there: I suspect the problem is then that the default tar in PATH on Windows in GitHub Actions is broken in https://github.com/ruby/ruby-builder/actions/runs/16365805938/job/46242634106#step:10:3 and omits jruby.exe when there is jruby.bat or something like that (I recall seeing this once in the past) Yep, that's MSP-Greg/setup-ruby#1 (comment) |
Sorry, something went wrong.
In jruby/jruby#8875 we modified JRuby's distribution to always ship scripts for bin/jruby and bin/ruby:
These changes now conflict with jruby-dev-builder's symlinking of bin/jruby to bin/ruby and its creation of bin/ruby.bat, so we remove the relevant steps.