FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix sporadic test failure by matthiasbeyer · Pull Request #75 · rust-cli/rexpect · GitHub

Fix sporadic test failure - #75

Merged
bors[bot] merged 1 commit into
rust-cli:masterfrom
matthiasbeyer:fix-sporadic-test
Oct 9, 2022
Merged

Fix sporadic test failure#75
bors[bot] merged 1 commit into
rust-cli:masterfrom
matthiasbeyer:fix-sporadic-test

Conversation

Copy link
Copy Markdown
Member
Details Closes #70

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>

Copy link
Copy Markdown
Member Author

So that made it work for now. @petreeftime what do you think? Is that enough? Or just a "sporadic success"? 😆

matthiasbeyer marked this pull request as ready for review October 9, 2022 08:26

Copy link
Copy Markdown
Member Author

I guess I can

bors try

to see whether this does the trick or fails again...

bors Bot added a commit that referenced this pull request Oct 9, 2022

bors Bot commented Oct 9, 2022

Copy link
Copy Markdown
Contributor

try

Build succeeded:

Copy link
Copy Markdown
Collaborator

The error seems to be caused by duplication of output, so I don't know whether this will help. I don't see a reason not to try, but I think there must be something that either was always buggy and interacts poorly with the test env, or caused by some minor change in nix 0.25 vs 0.14 that interacts poorly with the test env.

Copy link
Copy Markdown
Collaborator

bors merge

Copy link
Copy Markdown
Member Author

What I can think of is that the timeout is too short, and that caused the test to execute the following:

cat 
hans
hans: no such command

or something like that (because cat gets stopped too soon). I don't know for sure, of course, but that's the first thing I could think of.

Copy link
Copy Markdown
Member Author

Why does this take so long? Is bors overloaded right now? Weird... 🤔

bors Bot commented Oct 9, 2022

Copy link
Copy Markdown
Contributor

Build succeeded:

bors Bot merged commit 2151dab into rust-cli:master Oct 9, 2022
matthiasbeyer deleted the fix-sporadic-test branch October 9, 2022 10:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_read_line fails randomly

2 participants


Back | FazBrowse Home | New Git URL