Fix unsafe blocks in s![] macro - #1196
Merged
bluss merged 1 commit intoMar 9, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Closed
Copy link
Copy Markdown
Member
Author
|
CI results:
|
Sorry, something went wrong.
bluss
approved these changes
May 6, 2023
Before, the user could silently violate safety requirements of `SliceInfo::new_unchecked` by directly calling `s![@parse inconsistent_values]`, where `inconsistent_values` represents inconsistent values for the dimensions, etc. Now, the macro calls `SliceInfo::new_unchecked` only in the `($($t:tt)*)` arm, which always constructs the correct values for the call.
bluss
added this pull request to the merge queue
Mar 9, 2024
bluss
removed this pull request from the merge queue due to a manual request
Mar 9, 2024
bluss
added this pull request to the merge queue
Mar 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, the user could silently violate safety requirements of SliceInfo::new_unchecked by directly calling s![@parse inconsistent_values], where inconsistent_values represents inconsistent values for the dimensions, etc. Now, the macro calls SliceInfo::new_unchecked only in the ($($t:tt)*) arm, which always constructs the correct values for the call.