Add slice_axis_move method - #1211
Merged
bluss merged 1 commit intoMar 10, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
bluss
reviewed
Nov 12, 2022
Comment thread
src/impl_methods.rs
| /// | ||
| /// **Panics** if an index is out of bounds or step size is zero.<br> | ||
| /// **Panics** if `axis` is out of bounds. | ||
| #[must_use = "slice_axis_move returns an array with the sliced result"] |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
oh I was going to ask about the must_use, ownership semantics should mean we don't need it. But ArrayViews can be copy, so it applies well there. Nice catch.
Sorry, something went wrong.
bluss
approved these changes
Nov 12, 2022
bluss
enabled auto-merge
March 10, 2024 13:42
bluss
added this pull request to the merge queue
Mar 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.