Export Linspace and Logspace iterators - #1348
Merged
nilgoyette merged 4 commits intoJan 18, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
One could say that it's strange for ndarray to provide a lin/log-space iterator. Imo, this code already exist and we're already maintaining it. We might as well share it to make it useful to more people. 👍 I don't mind merging this. I'll wait one day to let the other maintainers express their opinion, if they want. |
Sorry, something went wrong.
lquenti
approved these changes
Jan 17, 2024
lquenti
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Thank you for your contribution @johann-cm |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple PR to make the Linspace and Logspace iterators, as well as the functions linspace, range, and logspace publicly available.
Resolves #1065.