FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update ci - run cross tests only on master by bluss · Pull Request #1366 · rust-ndarray/ndarray · GitHub

Update ci - run cross tests only on master - #1366

Merged
bluss merged 2 commits into
masterfrom
ci
Mar 9, 2024
Merged

Update ci - run cross tests only on master#1366
bluss merged 2 commits into
masterfrom
ci

Conversation

bluss commented Mar 9, 2024

Copy link
Copy Markdown
Member

Cross actions are very slow. They give us coverage on 32-bit and big endian, but are rather less important. Also update the checkout action because the old one has deprecation warnings.

Copy link
Copy Markdown
Collaborator

I think, ideally we'd use merge queues to run the cross asynchronously but before merging into the main branch. The PR workflow it self could then be simplify down even further, e.g. just tests on stable and Clippy.

bluss commented Mar 9, 2024
edited
Loading

Copy link
Copy Markdown
Member Author

sounds good, so like bors or whatever the new version would be

bluss merged commit 436b4c1 into master Mar 9, 2024
bluss deleted the ci branch March 9, 2024 13:49

Copy link
Copy Markdown
Collaborator

sounds good, so like bors or whatever the new version would be

Yes, but integrated into GitHub. You'll need to enable it in the project settings and then:

  • We don't run CI on the main branch at all any more because all commits are tested before being put there.
  • Which tests are run is not differentiated by branch name but by event, either pull requests or merge queues.
  • PR run should small and fast for quick feedback on proposed changes.
  • Pre-merge checks should be complete so that the main branch is always is a known good state.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL