Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I'm wondering what you think @adamreichold - if you have time. Cross tests are now a lot faster (I reduced the size of matrices tested by a good factor.), so speed should not be a problem. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Apologies for sending a question and then merging, but I'm moving quickly with these changes (when I actually do something). I still want to hear thoughts, even if this is already merged, it's easy to update. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've used Merge Queue well but now I want to try going back to using PR check instead.
The reason is that PR check allows maintainers to choose to integrate PRs using either squash, rebase or merge.
IMO squash should be preferred when the PR is one coherent change. Merge commit or rebase should be used when the PR is well split into different commits.
I find that we want to have both options available, and that's not possible with the merge queue.