Add .shrink_to_fit() for Array - #1424
Open
bluss wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
This is a new take on #1141. I don't think this is an easy topic, lots of details to work through. That's also why this change (in current state) does not change the Array strides. |
Sorry, something went wrong.
bluss
force-pushed
the
shrink-to-fit-2
branch
3 times, most recently
from
1e561b9 to
9688513
Compare
August 18, 2024 11:16
Add `.shrink_to_fit()` for owned storage arrays. This initial version does not change array strides, this is to avoid the most tricky part of the implementation (and maybe take it step by step). Care must be taken since `self.ptr` points inside the allocation - which for `Array` is still `Vec`-allocated, and several Vec methods including its `shrink_to_fit` can reallocate the array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add .shrink_to_fit() for owned storage arrays.
This initial version does not change array strides, this is to avoid the most tricky part of the implementation (and maybe take it step by step).
Care must be taken since self.ptr points inside the allocation - which for Array is still Vec-allocated, and several Vec methods including its shrink_to_fit can reallocate the array.