FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add axis_windows_with_stride() method by goertzenator · Pull Request #1460 · rust-ndarray/ndarray · GitHub

/ ndarray Public

add axis_windows_with_stride() method - #1460

Merged
akern40 merged 4 commits into
rust-ndarray:masterfrom
goertzenator:axis_windows_with_stride
May 21, 2025
ConversationCommits (4)ChecksFiles changed
Merged

add axis_windows_with_stride() method#1460
akern40 merged 4 commits into
rust-ndarray:masterfrom
goertzenator:axis_windows_with_stride

Conversation

goertzenator commented Dec 4, 2024

Copy link
Copy Markdown
Contributor

This adds a variation of axis_windows() that accepts a stride parameter. It is analogous to the windows_with_stride() variant of windows(). This was already 95% implemented thanks to the work of @jonasBoss in commit 2aec819.

Ref issue #1304.

akern40 reviewed Dec 13, 2024
View reviewed changes

akern40 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the PR! This is looking good, and great testing. Just the one question about keeping the name new. If you could run rustfmt (which must be run on +nightly) that would also be good.

Comment thread src/iterators/windows.rs
akern40 linked an issue Dec 13, 2024 that may be closed by this pull request
NdProducer::Dim of axis_windows() should be Ix1 #1304
Closed
goertzenator force-pushed the axis_windows_with_stride branch from 03fdd5f to c0961a6 Compare December 13, 2024 15:12

goertzenator commented Dec 13, 2024

Copy link
Copy Markdown
Contributor Author

cargo fmt from nightly has been applied to the PR.

akern40 commented Dec 14, 2024

Copy link
Copy Markdown
Collaborator

Let me fix our CI/CD and then this should be good to merge

akern40 marked this pull request as draft March 30, 2025 04:21
akern40 marked this pull request as ready for review March 30, 2025 04:21

akern40 commented Mar 30, 2025

Copy link
Copy Markdown
Collaborator

@goertzenator sorry I dropped the ball on this! Would you mind please running git commit --amend --no-edit then git push --force-with-lease on your branch? That should reset the CI which should go through and we can merge!

akern40 closed this May 20, 2025
akern40 reopened this May 20, 2025
akern40 force-pushed the axis_windows_with_stride branch from c0961a6 to a1dc7cd Compare May 21, 2025 00:15
akern40 force-pushed the axis_windows_with_stride branch from 183e1a0 to 5373073 Compare May 21, 2025 00:31
akern40 merged commit 0a8498a into rust-ndarray:master May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

akern40 akern40 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NdProducer::Dim of axis_windows() should be Ix1

2 participants

Back | FazBrowse Home | New Git URL