FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Accept owned arrays in `concatenate` and `stack` by watsaig · Pull Request #1592 · rust-ndarray/ndarray · GitHub

/ ndarray Public

Accept owned arrays in concatenate and stack - #1592

Open
watsaig wants to merge 5 commits into
rust-ndarray:masterfrom
watsaig:feat/stacking-owned-arrays
ConversationCommits (5)ChecksFiles changed
Open

Accept owned arrays in concatenate and stack#1592
watsaig wants to merge 5 commits into
rust-ndarray:masterfrom
watsaig:feat/stacking-owned-arrays

Conversation

watsaig commented May 1, 2026

Copy link
Copy Markdown

Closes #1591

The doc comments still sound correct imo, but please let me know if you think they need changes (or feel free to push changes yourself).

nilgoyette reviewed May 1, 2026
View reviewed changes
Comment thread src/stacking.rs Outdated

akern40 commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator

Would you mind rebasing on master and running the formatter with the nightly toolchain? Would be happy to merge after that

watsaig force-pushed the feat/stacking-owned-arrays branch from 2816113 to a7dcc69 Compare June 7, 2026 02:51

watsaig commented Jun 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Would you mind rebasing on master and running the formatter with the nightly toolchain? Would be happy to merge after that

Done! I ran cargo +nightly fmt which mostly reformatted files unrelated to my changes, I hope that's ok.

akern40 commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

Not sure what happened with your formatting command, but I went ahead and redid the formatting, we should be good to go now!

akern40 commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

(For reference I also just ran cargo +nightly fmt from the root)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nilgoyette nilgoyette left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Accept owned arrays in concatenate and stack

3 participants

Back | FazBrowse Home | New Git URL