Add contains() method to check if an index is within array bounds - #1593
Open
theoxfaber wants to merge 1 commit into
Open
Add contains() method to check if an index is within array bounds#1593theoxfaber wants to merge 1 commit into
theoxfaber wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Could you please add a test or two on the new method? And rebase off of master as well, to fix potential CI issues |
Sorry, something went wrong.
theoxfaber
force-pushed
the
add-contains-method
branch
from
0a1522b to
424f759
Compare
June 7, 2026 12:52
Copy link
Copy Markdown
Author
|
Rebased on master and added 3 tests (1D, 2D, and empty array). All 194 tests pass locally including the new ones. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Sorry I see a force push but it looks like it just contains your changes still |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
yeah rebased on master and added the tests you asked for. thanks for checking. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a contains() method to ArrayBase to check whether a given index falls within array dimensions without accessing the element.
Closes #1247
let a = arr2(&[[1., 2.], [3., 4.]]);
assert!(a.contains((0, 1)));
assert!(!a.contains((2, 0)));