fix(docs): point section links at the pages that define their anchors - #1606
Open
SomeB1oody wants to merge 1 commit into
Open
fix(docs): point section links at the pages that define their anchors#1606SomeB1oody wants to merge 1 commit into
SomeB1oody wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
The ArrayRef/LayoutRef refactor in rust-ndarray#1532 moved impl blocks off ArrayBase. The link text stayed put. Retarget each link at the page that actually defines the anchor. Docs only, no code change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1583
Summary
The ArrayRef/LayoutRef refactor in #1532 moved impl blocks off ArrayBase. The link text stayed put. This PR retargets each link at the page that actually defines the anchor. Docs only, no code change.
Notes
CI cannot catch this class of breakage because rustdoc splits a link target on # and only resolves the path before it. the fragment is copied into the URL unchecked. A bare #anchor is not treated as an intra-doc at all.