FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

update to tempfile 3.27.0 by Freax13 · Pull Request #563 · rust-osdev/bootloader · GitHub

/ bootloader Public

update to tempfile 3.27.0 - #563

Merged
Freax13 merged 3 commits into
rust-osdev:mainfrom
Freax13:fix/nightly-2026-05-10
May 14, 2026
ConversationCommits (3)ChecksFiles changed
Merged

update to tempfile 3.27.0#563
Freax13 merged 3 commits into
rust-osdev:mainfrom
Freax13:fix/nightly-2026-05-10

Conversation

Freax13 commented May 10, 2026

Copy link
Copy Markdown
Member

Previously, tempfile depended on an old rustix version that no longer builds on the latest nightly compiler. Bumping the tempfile crate also bumps rustix.

Supersedes #561

Freax13 added 3 commits May 10, 2026 09:09
update to tempfile 3.27.0
8486809 
Previously, tempfile depended on an old rustix version that no longer
builds on the latest nightly compiler. Bumping the tempfile crate also
bumps rustix.
exclude test kernels when linting workspace
678e365 
Something in cargo changed and now cargo clippy also seems to lint
binary dependencies. While that's reasonable, it also cause features to
be unified across the bootloader and test kernel crates and that's
causing issues.
Fix this by excluding the test kernels. The test kernels were already
linted seperatedly anyway.
fix warnings
ba5c4d3

Freax13 commented May 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

@jarovo I saw that you also made changes in #561 to move the disk buffer around. I'm not quite sure why that's needed. Is there a reason to do this?

Freax13 requested a review from phil-opp May 10, 2026 07:47
Freax13 mentioned this pull request May 10, 2026
Closed

jarovo commented May 10, 2026

Copy link
Copy Markdown

@jarovo I saw that you also made changes in #561 to move the disk buffer around. I'm not quite sure why that's needed. Is there a reason to do this?

Thanks for looking at the code and asking. I've just updated the PR description to specify the reasons for the changes.

phil-opp approved these changes May 14, 2026
View reviewed changes

phil-opp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, thank you!

Freax13 merged commit 5d97b89 into rust-osdev:main May 14, 2026
9 checks passed

Freax13 commented May 14, 2026

Copy link
Copy Markdown
Member Author

I don't think a release is necessary for this, it should be enough for user to just run cargo update. Please let me know if I'm wrong.

phil-opp mentioned this pull request Jul 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

phil-opp phil-opp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL