FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: fix some minor issues in comments by goldlinker · Pull Request #86 · rusticata/der-parser · GitHub

/ der-parser Public

chore: fix some minor issues in comments - #86

Open
goldlinker wants to merge 1 commit into
rusticata:masterfrom
goldlinker:master
ConversationCommits (1)ChecksFiles changed
Open

chore: fix some minor issues in comments#86
goldlinker wants to merge 1 commit into
rusticata:masterfrom
goldlinker:master

Conversation

goldlinker commented Oct 23, 2025 •
edited
Loading

Copy link
Copy Markdown

fix some minor issues in comments

chifflier requested changes Nov 19, 2025
View reviewed changes

chifflier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi, thank you for the pull request.
Fixing the spelling is good, so most changes approved, however some are not:
"Internet Widgits Pty Ltd" is not a real company, but a common placeholder name used by OpenSSL when generating some certificates. These ones should not be changed
Can you remove that part from the PR?

Comment thread tests/constructed.rs Outdated
Comment thread tests/constructed.rs Outdated
Comment thread tests/der_parser.rs Outdated
Comment thread tests/der_parser.rs Outdated
chore: fix some minor issues in comments
d9e4a42 
Signed-off-by: goldlinker <goldlinker@outlook.jp>
goldlinker changed the title chore: fix a large number of spelling issues chore: fix some minor issues in comments Dec 7, 2025

goldlinker commented Dec 7, 2025

Copy link
Copy Markdown
Author

Hi, thank you for the pull request. Fixing the spelling is good, so most changes approved, however some are not: "Internet Widgits Pty Ltd" is not a real company, but a common placeholder name used by OpenSSL when generating some certificates. These ones should not be changed Can you remove that part from the PR?

@chifflier
Thank you for your review. Reverted.

Please review it again.

goldlinker commented Feb 9, 2026

Copy link
Copy Markdown
Author

@chifflier Hi, Could you please review this PR at your convenience? Thank you very much.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

chifflier chifflier requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL