New feature for Counter Project: Add dark mode toggle, improve UI layout, and enhance accessibility - #84
Open
Jose-Renny wants to merge 3 commits into
Open
New feature for Counter Project: Add dark mode toggle, improve UI layout, and enhance accessibility#84Jose-Renny wants to merge 3 commits into
Jose-Renny wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Wrapped counter elements in a centered 'container-box for a card-like layout Added ARIA attributes: 'aria-live for counter updates and 'aria-label' for buttons Updated Font Awesome icon classes from 'fa' to 'fas' Added a dark mode toggle button for improved user experience Cleaned up spacing and structure for readability
- Created a card style container with padding, rounded corners, and shadow - Centered main content vertically and horizontally - Added spacing between buttons for a clearer layout - Implemented dark mode styles for body and container - Added smooth transitions for background, text color, and counter updates - Adjusted typography sizes for better visual hierarchy
- Moved counter update logicintoa reusable 'updateUI()' function - Updated counter text color based on value and dark mode state - Added event listener for dark mode toggle with immediate UI refresh - Simplified clickhandling using modern ES6 syntax and arrow functions - Improved readability and maintainability by centralizing logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR enhances the Counter Project by improving the UI design, adding a dark/light theme toggle, and introducing accessibility improvements
Changes Made:
- aria-live for counter updates
- aria-labels for buttons
Motivation:
These updates modernize the interface and improve usability and accessibility while maintaining the original functionality
Testing:
Here is the screeshots for comparing
Before:
After:
After (dark theme):