FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added support for stripping None-valued parameters by byronformwalt · Pull Request #415 · sammchardy/python-binance · GitHub

/ python-binance Public

Added support for stripping None-valued parameters - #415

Merged
sammchardy merged 3 commits into
sammchardy:bugfix/kline_charactersfrom
byronformwalt:master
Sep 21, 2019
ConversationCommits (3)ChecksFiles changed
Merged

Added support for stripping None-valued parameters#415
sammchardy merged 3 commits into
sammchardy:bugfix/kline_charactersfrom
byronformwalt:master

Conversation

byronformwalt commented Aug 13, 2019

Copy link
Copy Markdown
Contributor
  • In Client._get_earliest_valid_timestamp(), endTime is set to None, which results in a server-side error.

Added support for stripping None-valued parameters
006a3f4 
 - In Client._get_earliest_valid_timestamp(), endTime is set to None, which results in a server-side error.
Fixed white-space travis-ci complaint.
cb036c8
Final attempt at satisfying travis-ci.
7ab0285
This was referenced Aug 19, 2019
Closed
Closed
sammchardy changed the base branch from master to bugfix/kline_characters August 22, 2019 09:28

sammchardy commented Aug 22, 2019

Copy link
Copy Markdown
Owner

Thanks @byronformwalt

drbh commented Sep 4, 2019

Copy link
Copy Markdown

This is a good PR 👍

Looking forward to the merge

sammchardy merged commit 81cd618 into sammchardy:bugfix/kline_characters Sep 21, 2019

Gelso22 commented Jan 20, 2021

Copy link
Copy Markdown

Hello I have the same error:
binance.exceptions.BinanceAPIException: APIError(code=-1100): Illegal characters found in parameter 'interval'; legal range is '^[a-zA-Z0-9]{1,36}$'

But I don't get how to fix it.. What function I have to modify?
Sorry but I have no experience

Talhabhurgri1 commented Jun 2, 2021

Copy link
Copy Markdown

Hello I have the same error:
binance.exceptions.BinanceAPIException: APIError(code=-1100): Illegal characters found in parameter 'interval'; legal range is '^[a-zA-Z0-9]{1,36}$'

But I don't get how to fix it.. What function I have to modify?
Sorry but I have no experience

I have the same issue need help too

smallham1 commented Jun 3, 2021

Copy link
Copy Markdown

having a similar issue when trying to withdraw. APIError(code=-1100): Illegal characters found in a parameter. is the response i get with any line that has client.withdraw in it so even a blank () or get_withdraw_history doesnt work.

sammchardy commented Jun 3, 2021

Copy link
Copy Markdown
Owner

Looks like this change got reverted in v1, will add it back in again.

sammchardy commented Jun 3, 2021

Copy link
Copy Markdown
Owner

has been fixed in v1.0.12 with tests

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL