Type checking improvements - #103
Closed
bringhurst wants to merge 1 commit into
Closed
Conversation
- Add a PEP 561 marker file (py.typed). - Run mypy during CI. - Update black to avoid pallets/click#2225 - Update mkdocs to avoid mkdocs/mkdocs#2799 - Disable mkdocs strict mode to avoid mkdocs/mkdocs#2252
Copy link
Copy Markdown
Author
|
Note the ignore lines in mypy.ini. # # Please do not add any additional mypy ignores in this section! # [mypy-devtools.utils] # FIXME: Remove this ignore after fixing type errors. ignore_errors = true [mypy-devtools.prettier] # FIXME: Remove this ignore after fixing type errors. ignore_errors = true [mypy-devtools.ansi] # FIXME: Remove this ignore after fixing type errors. ignore_errors = true [mypy-devtools.debug] # FIXME: Remove this ignore after fixing type errors. ignore_errors = true This was done so mypy warnings/errors can be fixed in bite-sized PRs. Fixing all of those at once would be quite a large change. If this PR is merged, a new issue should be opened to track fixing these. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Discarding due to inactivity. |
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
|
So sorry, I missed this complete. Feel free to reopen this and I'll review it this week. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
No hard feelings. 😄 I was just bulk closing old PRs. TY for fixing it up! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.