Add option to change print function by barabum0 · Pull Request #145 · samuelcolvin/python-devtools · GitHub

I added logger_function parameter to Debug() class that replaces print if set. Here is an example of usage with loguru:

from devtools import Debug
from loguru import logger

debug = Debug(logger_function=logger.debug)

test_object = {
    "string": "test",
    "integer": 123,
    "nested": {
        "key": "value"
    }
}
debug(test_object)
# 2023-10-29 18:38:45.211 | DEBUG    | devtools.debug:__call__:127 - logger_func_test.py:13 <module>
#     test_object: {
#         'string': 'test',
#         'integer': 123,
#         'nested': {
#             'key': 'value',
#         },
#     } (dict) len=3

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.03%. Comparing base (ec406ff) to head (fb8c506).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
devtools/debug.py	60.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   96.29%   96.03%   -0.26%     
==========================================
  Files           8        8              
  Lines         729      732       +3     
  Branches      111      112       +1     
==========================================
+ Hits          702      703       +1     
- Misses         21       22       +1     
- Partials        6        7       +1

Files with missing lines	Coverage Δ
devtools/debug.py	98.48% <60.00%> (-1.52%)	⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec406ff...fb8c506. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

added some commits to please lint checker

…rgs)

CI / lint (pull_request) Failing after 1m

I actually don't know whats wrong with my code (if so). But my feature is working correctly, so please review and merge it

If logger_function would have the same signature as print, you could initialize it to print per default.
That way you can get rid of the conditional code in __call__. One might have to wrap a logger into a lambda to ignore the additonal file/flush arguments.

CI / lint (pull_request) Failing after 1m

I actually don't know whats wrong with my code (if so). But my feature is working correctly, so please review and merge it

While I am not involved with the project, you might be able to fix your issue: apparently you overindented something, try reformatting with black and committing. You can see the ci issue here: https://github.com/samuelcolvin/python-devtools/actions/runs/6684613574/job/18162063139?pr=145#step:6:158

add logging_function

edf6d11

Optional cuz of mypy

a669149

lint checker please accept my code (reordered imports and rewritten a…

fb8c506

…rgs)

barabum0 changed the title Add logging_function parameter Add option to change print function Oct 29, 2023

maltevesper reviewed Nov 28, 2023

View reviewed changes

+                          *,
+                          warnings: 'Optional[bool]' = None,
+                          highlight: 'Optional[bool]' = None,
+                          logger_function: 'Optional[Callable[[str], None]]' = None,

Add option to change print function by barabum0 · Pull Request #145 · samuelcolvin/python-devtools · GitHub

Uh oh!

Add option to change print function - #145

Add option to change print function#145
barabum0 wants to merge 3 commits into
samuelcolvin:mainfrom
barabum0:main

barabum0 commented Oct 29, 2023

Uh oh!

codecov Bot commented Oct 29, 2023 •
edited
Loading

Uh oh!

Uh oh!

barabum0 commented Oct 29, 2023 •
edited
Loading

Uh oh!

Uh oh!

barabum0 commented Oct 29, 2023

Uh oh!

maltevesper Nov 28, 2023

Uh oh!

maltevesper commented Nov 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add option to change print function by barabum0 · Pull Request #145 · samuelcolvin/python-devtools · GitHub

Uh oh!

Add option to change print function - #145

Add option to change print function#145barabum0 wants to merge 3 commits intosamuelcolvin:mainsamuelcolvin/python-devtools:mainfrom barabum0:mainbarabum0/python-devtools-pr:mainCopy head branch name to clipboard

Conversation

barabum0 commented Oct 29, 2023

Uh oh!

codecov Bot commented Oct 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

barabum0 commented Oct 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

barabum0 commented Oct 29, 2023

Uh oh!

maltevesper Nov 28, 2023

Choose a reason for hiding this comment

Uh oh!

maltevesper commented Nov 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add option to change print function#145
barabum0 wants to merge 3 commits into
samuelcolvin:mainfrom
barabum0:main

codecov Bot commented Oct 29, 2023 •
edited
Loading

barabum0 commented Oct 29, 2023 •
edited
Loading