🐛 Don't render None as the backport PR body - #58
Conversation
Sorry, something went wrong.
webknjaz
left a comment
There was a problem hiding this comment.
Alright.. I suppose this is a good solution for now. I wasn't sure what to do with this case originally (whether to display some explanatory text or a hidden html comment for troubleshooting). Plus not having tests in the project doesn't make it a good environment for first time contributors. So I won't request additional work on top here. Thanks!
However, if you'd like to work on some test infra for this bot — more PRs are welcome.
Sorry, something went wrong.
|
Thanks for the review and merge! #57 is still open if it's useful, and if there's anything else here you'd like picked up, feel free to ping me. |
Sorry, something went wrong.
pull_request['body'] is null for PRs submitted without a description, so the f-string interpolated the string None into the backport PR description.
Live example from #49: aio-libs/aiohttp#11772 ends with
Now the original description is only appended when there is one. Output is unchanged for PRs that do have a body; the empty-string case also stops emitting a trailing blank block.
Fixes #49.