This repository was archived by the owner on Jul 24, 2023. It is now read-only.
[osx] adding preprocessor directives to fix include on OSX. - #48
Open
truthbk wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
sbinet
reviewed
Jan 3, 2017
sbinet
left a comment
Copy link
Copy Markdown
Owner
There was a problem hiding this comment.
thanks for this.
one question though... (see below)
Sorry, something went wrong.
Comment thread
go-python.h
| #include "Python.h" | ||
| #endif | ||
|
|
||
| #include "frameobject.h" |
Copy link
Copy Markdown
Owner
There was a problem hiding this comment.
shouldn't all the other "internal" python-related headers be picked up from under "Python/..." as well?
Sorry, something went wrong.
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
That is totally correct... I will update the PR.
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
|
perhaps this could be better handled w/ pkg-config, like in #28 (comment) ? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having issues building on OSX.
Python is provided as a framework by Xcode, and has to be included as #include "Python/Python.h" as opposed to the expected in #include "Python.h" in other environments (ie. Linux). I think this is probably better than messing with the include paths.
The provided fix did it for me.
Thanks!