infer env params - rfc - #52
Open
syandroo wants to merge 4 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
syandroo
commented
Aug 2, 2022
Comment thread
launch/utils.py
| try: | ||
| ver = torch.__version__.split("+") | ||
| torch_version = ver[0] | ||
| cuda_version = ver[1][2:] if len(ver) > 1 else "113" |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
can also default to "latest" if parsing goes awry but i'm hesitant cuz upstream build issues are worse than client side errors
Sorry, something went wrong.
Comment thread
launch/utils.py
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just a proof of concept, we infer the image tags instead of having users manually set an image tag
chipping away at all the required fields back to reasonable defaults
tried to make it as un-jank as possible, and added errors so users can just fall back to image tags