Add making requests to synchronous endpoints - #225
Conversation
Sorry, something went wrong.
| for endpoint in resp["endpoints"] | ||
| if endpoint["endpoint_type"] == "sync" | ||
| ] | ||
| return async_endpoints + sync_endpoints |
There was a problem hiding this comment.
Don't the set of async and sync endpoints comprise the full set of possible endpoints? If so, can we just return resp["endpoints"]?
Sorry, something went wrong.
There was a problem hiding this comment.
It is the full set of endpoints, but the object returned is a list of either SyncModelEndpoints or AsyncModelEndpoints, so we have to construct them separately (or do something like modelEndpointClass = SyncModelEndpoint if <x> else Async)
Sorry, something went wrong.
| def __str__(self): | ||
| return f"SyncModelEndpoint <endpoint_id:{self.endpoint_id}>" | ||
|
|
||
| def predict_one(self, url): |
There was a problem hiding this comment.
Can we just call this predict?
Also, non-url inputs are in a different ticket, right?
Sorry, something went wrong.
There was a problem hiding this comment.
re non-url inputs, they are in a different ticket, and I'm inclined to just open a different pr for them as well at this point
re predict, have offline discussion
Sorry, something went wrong.
Companion pr to https://github.com/scaleapi/models/pull/2584
Work for both https://app.shortcut.com/scaleai/story/381256/ and https://app.shortcut.com/scaleai/story/379721/