FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Refactor a lot of segmentation local upload and async logic by ardila · Pull Request #256 · scaleapi/nucleus-python-client · GitHub

/ nucleus-python-client Public

Refactor a lot of segmentation local upload and async logic - #256

Merged
ardila merged 11 commits into
masterfrom
da-local-segmentation
Mar 16, 2022
ConversationCommits (11)ChecksFiles changed
Merged

Refactor a lot of segmentation local upload and async logic#256
ardila merged 11 commits into
masterfrom
da-local-segmentation

Conversation

ardila commented Mar 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Refactor async related code to its own module so it is easier to reuse
  • Refactor out annotation upload logic since we are making it even more complex. Move it to its own module as well.
  • Fix issues with retries/clarify typing throughout async code
  • Add local upload for masks.
  • Delete some unused/irrelevant methods in base client.

ardila changed the title Cleanup Asycn Form Data requests + Segmentation local upload Refactor a lot of segmentation local upload and async logic Mar 11, 2022
gatli approved these changes Mar 14, 2022
View reviewed changes

gatli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! 👍 🔥

Comment thread nucleus/annotation.py Outdated
Comment thread nucleus/annotation_uploader.py
Comment thread nucleus/annotation_uploader.py
Comment thread nucleus/annotation_uploader.py Outdated
Comment thread nucleus/annotation_uploader.py
Comment thread tests/test_segmentation.py Outdated
Comment thread tests/test_segmentation.py Outdated
Comment thread tests/test_segmentation.py Outdated
Comment thread tests/test_segmentation.py Outdated
Comment thread tests/test_segmentation.py Outdated
ardila force-pushed the da-local-segmentation branch from 530e64a to 5b501d1 Compare March 15, 2022 17:36
ardila merged commit 9040e04 into master Mar 16, 2022
ardila deleted the da-local-segmentation branch March 16, 2022 18:20
gatli pushed a commit that referenced this pull request Mar 30, 2022
Refactor a lot of segmentation local upload and async logic (#256)
203d0f2 
* work in progress

* work in progress

* Big refactor to make things cleaner + enable retries properly on infra flakes for local upload

* work in progress refactor of annotation upload

* Fixed segmentation bugs

* Fix one more bug and remove use of annotate_segmentation endpoint

* refactor tests and add segmentation local upload test

* Tests passing

* Review feedback

* Initial pass at client changes for prediction segmentation upload

* relevant tests pass

Co-authored-by: Ubuntu <diego.ardila@scale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gatli gatli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL