FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add id fields to Annotations and Predictions for traceability by gatli · Pull Request #288 · scaleapi/nucleus-python-client · GitHub

Add id fields to Annotations and Predictions for traceability - #288

Open
gatli wants to merge 5 commits into
masterfrom
gunnar/nucleus/add-id-field-to-annotations-and-preds
Open

Add id fields to Annotations and Predictions for traceability#288
gatli wants to merge 5 commits into
masterfrom
gunnar/nucleus/add-id-field-to-annotations-and-preds

Conversation

gatli commented Apr 26, 2022

Copy link
Copy Markdown
Contributor

When loading annotations and predictions that have assigned IDs there was no way of searching for those in the frontend. This adds and ID field that is populated when loading Annotations and Predictions from server.

gatli requested a review from drakejwong April 26, 2022 12:26
gatli self-assigned this Apr 26, 2022

Copy link
Copy Markdown
Contributor

Reiterating from Slack thread for visibility:
I'm not sure if we should pollute the constructor params, since it risks the user interpreting this as a value they can supply (e.g. when tab completing via the function signature).

What do you think of an id property — this also extends to DatasetItem, Dataset, Slice, Model, etc — rather than a constructor param? This way we can better handle the case where the object has not yet hit our backend to have an ID generated.

Base automatically changed from gunnar/validate/fix-invalid-poly-matching to master May 4, 2022 12:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL