Add ungrouped function from deprecated class to model class - #448
Open
ankitvedakscale wants to merge 1 commit into
Open
Add ungrouped function from deprecated class to model class#448ankitvedakscale wants to merge 1 commit into
ankitvedakscale wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
jean-lucas
reviewed
Mar 14, 2025
jean-lucas
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Please also update the version in the .toml file and add a description in the releases
Sorry, something went wrong.
Comment thread
nucleus/model.py
Comment on lines
+348
to
+354
| def ungrouped_export(self, model_run_id): | ||
| json_response = self._client.make_request( | ||
| payload={}, | ||
| route=f"modelRun/{model_run_id}/ungrouped", | ||
| requests_command=requests.get, | ||
| ) | ||
| return format_prediction_response({ANNOTATIONS_KEY: json_response}) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Lets name this something a bit better. I'm not sure why the endpoint was originally named ungrouped, but this method could be called export_by_model_run_id or something like that
Sorry, something went wrong.
jean-lucas
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reusing a function from the Deprecated ModelRun to Model Class