FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add community guide by juanis2112 · Pull Request #58 · scientific-python/learn.scientific-python.org · GitHub

Add community guide - #58

Merged
InessaPawson merged 1 commit into
scientific-python:mainfrom
juanis2112:community-guide
May 28, 2023
Merged

Add community guide#58
InessaPawson merged 1 commit into
scientific-python:mainfrom
juanis2112:community-guide

Conversation

Copy link
Copy Markdown
Member

Co-authored-by: Sanket Verma svsanketverma5@gmail.com
Co-authored-by: Inessa Pawson inessapawson@gmail.com

netlify Bot commented May 27, 2023
edited
Loading

Copy link
Copy Markdown

Deploy Preview for learn-scientific-python-org failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit cc33cde
🔍 Latest deploy log https://app.netlify.com/sites/learn-scientific-python-org/deploys/64715932144a8f0008f67525

Co-authored-by: Sanket Verma <svsanketverma5@gmail.com>
Co-authored-by: Inessa Pawson <inessapawson@gmail.com>
juanis2112 marked this pull request as ready for review May 27, 2023 01:13

InessaPawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is a great first draft. Thank you, @juanis2112 and @MSanKeys963!

InessaPawson merged commit d3d0469 into scientific-python:main May 28, 2023
sanketverma1704 mentioned this pull request May 28, 2023

Copy link
Copy Markdown
Member

I think this PR needs some fixing. The CI is failing, and I can't see the content over at https://learn.scientific-python.org/community/.

I tried fixing pre-commit errors in #59, but some tests are failing. Any ideas?

CC: @juanis2112 @jarrodmillman @stefanv

Copy link
Copy Markdown
Member

@InessaPawson We should make sure that the CI is passing before merging PRs. I will fix this in @MSanKeys963 PR #59. Thanks!!

Copy link
Copy Markdown
Member Author

I think it just need rebasing since I don’t think I had in my branch the changes added to build the developers guide @jarrodmillman @MSanKeys963

stefanv commented May 30, 2023

Copy link
Copy Markdown
Member

I think it just need rebasing

Here's a list of the changes @jarrodmillman had to make to get it to pass.

Copy link
Copy Markdown
Member Author

Sorry @jarrodmillman. I’m pretty sure I ran the pre-commit and wasn’t expecting it to have so many errors.
Also @stefanv we were working with jarrod during the summit and he was helping me fix the PR but we never got to fixing it. After a while of looking at the errors Jarrod suggested that it was probably due to my PR being behind the main branch after the scikit hep guide changes were merged. Hence I thought that’s what was wrong with the PR.

stefanv commented May 30, 2023

Copy link
Copy Markdown
Member

Hehe, yeap, I caused a bit of trouble there, but all good---it's sorted :)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL